[Fix #5261] Fix false positive for Style/MixinUsage when using inside module
#5272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
reviewed
Dec 18, 2017
| @@ -58,6 +68,28 @@ class C | |||
| RUBY | |||
| end | |||
|
|
|||
| it 'registers an offense when using `include` in method definition ' \ | |||
There was a problem hiding this comment.
There was a slight misunderstanding. This was good with registers, the other was not good. #5272 (comment)
Thank you for pointing out.
bbatsov
reviewed
Dec 18, 2017
| RUBY | ||
| end | ||
|
|
||
| it 'registers an offense when using `include` in method definition ' \ |
koic
force-pushed
the
fix_false_positive_for_style_mixin_cop
branch
from
df1e39c
to
ee78395
Compare
…ng inside module Fixes rubocop#5261. Correspondence to use case for `include` belonging to module was insufficient. This PR added a reproduction test and fixed it.
koic
force-pushed
the
fix_false_positive_for_style_mixin_cop
branch
from
ee78395
to
1e491db
Compare
|
For the record: This PR also seems to fix false positives that we're seeing with 0.52.0 on code like class Foo
if GlobalConfig.special_logging?
include LogInstrumentation
end
end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5261.
Correspondence to use case for
includebelonging to module was insufficient. This PR added a reproduction test and fixed it.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
rake defaultorrake parallel. It executes all tests and RuboCop for itself, and generates the documentation.