Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing faces for tab-bar mode #427

Closed
exot opened this issue Sep 18, 2021 · 0 comments
Closed

Missing faces for tab-bar mode #427

exot opened this issue Sep 18, 2021 · 0 comments

Comments

@exot
Copy link

exot commented Sep 18, 2021

Hey,

it appears that the solarized-themes are missing faces for tab-bar-mode (not to be confused with tabbar-mode, for which face definitions are already present). Today I found some time to tinker with this and came up with the following snippet for my init.el:

(setq custom--inhibit-theme-enable nil)

(custom-theme-set-faces
    'solarized-dark
    `(tab-bar ((t (:height 1.2
                         :foregreound ,(cdr (assoc 'base03 solarized-dark-color-palette-alist))
                         :background ,(cdr (assoc 'base03 solarized-dark-color-palette-alist))))))
    `(tab-bar-tab ((t (:background ,(cdr (assoc 'base02 solarized-dark-color-palette-alist))
                               :foreground ,(cdr (assoc 'magenta solarized-dark-color-palette-alist))
                               :inverse-video nil
                               :box (:line-width 1 :style released-button)))))
    `(tab-bar-tab-inactive ((t (:inherit tab-bar-tab
                                            :background ,(cdr (assoc 'base0 solarized-dark-color-palette-alist))
                                            :foreground ,(cdr (assoc 'base03 solarized-dark-color-palette-alist))
                                            :inverse-video t
                                            :box nil)))))

(Parts of this have been take from the sanityinc-tomorrow-night theme).

That's quite a crutch I guess, but it seems to work for the time being …

Would it be helpful to have those definitions (when sufficiently adapted) being added to the main solarized-definition variable? In that case, I could prepare a PR, or somebody could just copy that over to solarized-faces.el.

Best,

  Daniel

@thomasf thomasf closed this as completed Aug 4, 2023
exot added a commit to exot/.emacs.d that referenced this issue Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants