Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binary_url doesn't adhere to version or mirror #47

Closed
optix2000 opened this issue May 23, 2017 · 4 comments
Closed

binary_url doesn't adhere to version or mirror #47

optix2000 opened this issue May 23, 2017 · 4 comments
Labels
Milestone

Comments

@optix2000
Copy link

Probably related to 08161d4

If you override version or mirror in a wrapper cookbook, the binary_url isn't changed with it.

ie zookeeper-wrapper/recipes/default.rb

include_recipe 'apache_zookeeper'

zookeeper-wrapper/attributes/default.rb

default['apache_zookeeper']['mirror'] = 'https://mirrors.ocf.berkeley.edu/apache/zookeeper/'
default['apache_zookeeper']['version'] = '3.4.10'

Results in this being rendered as the node attributes:

    apache_zookeeper: !ruby/hash-with-ivars:Chef::Node::ImmutableMash
      elements:
        install_java: true
        install_dir: "/opt/zookeeper"
        version: 3.4.10
        mirror: https://mirrors.ocf.berkeley.edu/apache/zookeeper/
        binary_url: http://archive.apache.org/dist/zookeeper/zookeeper-3.4.6/zookeeper-3.4.6.tar.gz

It looks like the render order for attributes doesn't allow binary_url to be rendered dynamically from overriding attributes while it's in attributes.rb

@optix2000
Copy link
Author

binary_url probably needs to be rendered in the recipe, with a check to see if there's an attribute override.

@bbaugher bbaugher added the bug label May 24, 2017
@bbaugher bbaugher added this to the 1.1.1 milestone May 24, 2017
@bbaugher
Copy link
Owner

Fixed

@bbaugher
Copy link
Owner

@optix2000
Copy link
Author

Thanks for the quick turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants