Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of attempts being a timing stat doesn't seem right #32

Closed
MamathaNair opened this issue Aug 8, 2016 · 3 comments
Closed

Number of attempts being a timing stat doesn't seem right #32

MamathaNair opened this issue Aug 8, 2016 · 3 comments

Comments

@MamathaNair
Copy link

In lib/client.js, the stats for number of attempts are send as a timing stat.

client.stats.timing(statsName + '.attempts', currentAttempts);

@robinjmurphy
Copy link
Contributor

Hi @MamathaNair. Yep that's on purpose. It may seem a little counter-intuitive but it means you can get a mean, max, min etc. for the value. Are you having a particular issue with it?

@MamathaNair
Copy link
Author

@robinjmurphy No it just seemed odd. Thanks for replying.

@robinjmurphy
Copy link
Contributor

No worries. This is a graph that we render using the timer.

screen shot 2016-08-08 at 11 20 22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants