Allow client to be created asynchronously #74
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasR
suggested changes
Sep 8, 2017
| opts.cache.start(function(err) { | ||
| client = new CachingClient(client, opts); | ||
| error = err; | ||
| }); |
There was a problem hiding this comment.
If you want to wait for Catbox to finish initialising, would it make more sense to put the callback in here?
|
Hello @subvertnormality, |
|
Hi @niklasR we've decided to go down a different route, happy to close this if you feel it doesn't add anything to the library at this time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As outlined in #72 - sometimes we need to allow the client to connect to a Redis instance before attempting to make a request. For this reason a createClientAsync function is useful.
This is a callback version of the other PR I raised.