Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the styles to improve legibility and use BBC Reith typefaces #38

Closed
JoshTumath opened this issue May 15, 2020 · 2 comments
Closed
Labels
enhancement New feature or request

Comments

@JoshTumath
Copy link

JoshTumath commented May 15, 2020

Is your feature request related to a problem? Please describe.

  • The body text is a bit small and the line spacing is a bit tight
  • The width of the body is quite wide, so lines of text are quite long, but research shows roughly 60 characters per line is the best for readability.
  • It would be nice to add the BBC Reith typefaces

Describe the solution you'd like

  • Update the font styles to match GEL guidelines around font styles, which should improve legibility and the reading experience
  • Give the body a max-width of 60ch units (falling back to approx ~ 33em units if that's not supported)
  • Use black text for headings
  • Use Reith Serif for h1 headings and Reith Sans for the rest of the text

I would be happy to submit a PR for this change if the project maintainers are OK with it.

@adamjc
Copy link
Contributor

adamjc commented May 15, 2020

This sounds like a great idea! I'm all for it

@fuzzyfelt
Copy link
Contributor

We've made some adjustments to the sizing but can't use the Reith font.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants