Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Merge CI task should publish Storybook #167

Closed
1 task done
ChrisBAshton opened this issue Dec 10, 2018 · 2 comments
Closed
1 task done

Merge CI task should publish Storybook #167

ChrisBAshton opened this issue Dec 10, 2018 · 2 comments
Assignees

Comments

@ChrisBAshton
Copy link
Contributor

ChrisBAshton commented Dec 10, 2018

Is your feature request related to a problem? Please describe.
Blocked on #165 and #37.

When a PR is merged, we should run our storybook-deploy task, which builds and deploys the latest Storybook to gh-pages.

Add Jenkins as a collaborator. Create a new access token - ideally that can only push to gh-pages if possible. Make gh-pages locked down to admins and Jenkins.

Describe the solution you'd like
Add Storybook publishing to the CI pipeline.

Describe alternatives you've considered
Continue doing this manually from the command line after each merge (error-prone).

Testing notes
[Tester to complete]

Dev insight: Create a new package or bump a version of an existing package (example-button maybe?) and when PR is merged, that component should be visible at https://bbc-news.github.io/psammead.

@ChrisBAshton ChrisBAshton added alpha-2 blocked This issue should not be worked on until another internal issue is completed - see desc for details Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. labels Dec 10, 2018
@ChrisBAshton ChrisBAshton added this to To do in Articles via automation Dec 10, 2018
@ChrisBAshton ChrisBAshton added must and removed Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. labels Dec 10, 2018
@dr3
Copy link
Contributor

dr3 commented Dec 13, 2018

I dont think this is really blocked on #165 @ChrisBAshton

@dr3 dr3 removed the blocked This issue should not be worked on until another internal issue is completed - see desc for details label Dec 13, 2018
@dr3 dr3 moved this from To do to Issue In progress in Articles Dec 13, 2018
@dr3 dr3 self-assigned this Dec 13, 2018
@dr3 dr3 mentioned this issue Dec 13, 2018
3 tasks
@ChrisBAshton
Copy link
Contributor Author

Fair. #165 was about setting up a new job, originally - not needed anymore!

@dr3 dr3 closed this as completed in #194 Dec 13, 2018
Articles automation moved this from Issue In progress to Done Dec 13, 2018
@ChrisBAshton ChrisBAshton removed this from Done in Articles Jan 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants