Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Use react-testing-library in Psammead #273

Closed
1 task done
radiocontrolled opened this issue Jan 16, 2019 · 0 comments · Fixed by #732
Closed
1 task done

Use react-testing-library in Psammead #273

radiocontrolled opened this issue Jan 16, 2019 · 0 comments · Fixed by #732
Assignees
@jroebu14
Labels
simorgh-core-stream
Projects
Simorgh

Comments

@radiocontrolled
Copy link
Contributor

radiocontrolled commented Jan 16, 2019 •
edited by jamesbrumpton

Is your feature request related to a problem? Please describe.
We should update Psammead's test helpers so that they use react-testing-library

Describe the solution you'd like

  1. Update psammead's test helpers to include react-testing-library

Describe alternatives you've considered
Related: [POC] [Do not merge] testing library alternatives for Simorgh

Testing notes
This will not require Cypress tests. From my understanding, this will require a run of the tests on Psammead just to confirm that the change hasn't broken the existing logic.

Dev insight: Will Cypress tests be required or are unit tests sufficient? Will there be any potential regression? etc

Additional context
Add any other context or screenshots about the feature request here.
@radiocontrolled radiocontrolled added Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. alpha-3 labels Jan 16, 2019
@radiocontrolled radiocontrolled added this to To do in Simorgh via automation Jan 16, 2019
This was referenced Jan 16, 2019
Closed
Closed
@radiocontrolled radiocontrolled removed the Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. label Jan 16, 2019
@ChrisBAshton ChrisBAshton mentioned this issue Mar 13, 2019
Closed
1 task
@jroebu14 jroebu14 self-assigned this Jun 27, 2019
@jroebu14 jroebu14 removed their assignment Jun 27, 2019
@jroebu14 jroebu14 self-assigned this Jun 27, 2019
@jroebu14 jroebu14 removed this from To do in Simorgh Jun 28, 2019
@jroebu14 jroebu14 added this to To do in Simorgh via automation Jun 28, 2019
@jroebu14 jroebu14 moved this from To do to PR in Progress in Simorgh Jun 28, 2019
This was referenced Jun 28, 2019
Closed
Closed
Merged
@jroebu14 jroebu14 moved this from PR in Progress to Code review in Simorgh Jul 1, 2019
@thekp thekp moved this from Code review to Issue in Progress in Simorgh Jul 1, 2019
Simorgh automation moved this from Issue in Progress to Done Jul 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jroebu14 jroebu14

Labels
simorgh-core-stream
Projects
No open projects
Simorgh
Done
Milestone
No milestone
4 participants
@radiocontrolled @jroebu14 @ChrisBAshton @benjaminhobbs