Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove as many consts and lets from cypress tests as possible #2919

Closed
oluoluoxenfree opened this issue Aug 6, 2019 · 0 comments
Closed

Remove as many consts and lets from cypress tests as possible #2919

oluoluoxenfree opened this issue Aug 6, 2019 · 0 comments
Assignees
@oluoluoxenfree
Projects
Simorgh

Comments

@oluoluoxenfree
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Using const and let in cypress tests is against best practices. This ticket aims to remove as many as possible.

Describe the solution you'd like
One PR per file to keep it short and neat

Describe alternatives you've considered
N/A

Testing notes
[Tester to complete]

Dev insight: Will Cypress tests be required or are unit tests sufficient? Will there be any potential regression? etc

Additional context
Add any other context or screenshots about the feature request here.
@oluoluoxenfree oluoluoxenfree added Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. simorgh-core-stream labels Aug 6, 2019
@oluoluoxenfree oluoluoxenfree self-assigned this Aug 6, 2019
@oluoluoxenfree oluoluoxenfree added this to To do in Simorgh via automation Aug 6, 2019
@oluoluoxenfree oluoluoxenfree removed the Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. label Aug 6, 2019
@oluoluoxenfree oluoluoxenfree moved this from To do to Issue in Progress in Simorgh Aug 6, 2019
@oluoluoxenfree oluoluoxenfree changed the title Remove as many consts and lets from cypress test as possible Remove as many consts and lets from cypress tests as possible Aug 6, 2019
@oluoluoxenfree oluoluoxenfree mentioned this issue Aug 6, 2019
Closed
3 tasks
Simorgh automation moved this from Issue in Progress to Done Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oluoluoxenfree oluoluoxenfree

Labels
None yet
Projects
No open projects
Simorgh
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oluoluoxenfree