Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - Social embeds not always rendering #9812

Closed
LilyL0u opened this issue Jan 20, 2022 · 1 comment · Fixed by #9826
Closed

Bug - Social embeds not always rendering #9812

LilyL0u opened this issue Jan 20, 2022 · 1 comment · Fixed by #9826
Assignees
Labels
bug Something isn't working low-priority
Projects

Comments

@LilyL0u
Copy link
Contributor

LilyL0u commented Jan 20, 2022

We have an E2E test that sometimes fails. The test takes the social embed URLs from the json and scrolls to the top 3 in turn, with a wait of 3 seconds in between to allow time for them to appear with the lazy loading. It counts the number of ‘.instagram-media-rendered’ that appear. These appear when the social media embed renders.

Here is an example of one of the tests failing on this:
Screenshot 2022-01-19 at 17 14 19

It expected 3 social embeds to render, but only counted 1. This is either because they loaded too slowly and the test scrolled past before counting them, or they didn't render at all.

I had a look at the page to see if I can see this happening manually and I did catch one of the social embeds not rendering at all, so it is a real problem:

Screenshot 2022-01-19 at 17 59 33

The comments above the test read

// This test specifically covers an edge case where more than one instagram post is
// included in a Story and instagram needs to be prompted to render the instagram post
// rather than leaving it as core content
//
// Specifically it runs against this asset http://localhost:7080/russian/news-55041160
// but should pass against any page Story page with 2 or more instagram posts

@LilyL0u LilyL0u created this issue from a note in Simorgh (Backlog (Ready for dev)) Jan 20, 2022
@LilyL0u LilyL0u added the bug Something isn't working label Jan 20, 2022
@MuhammadAHussain MuhammadAHussain self-assigned this Jan 26, 2022
@MuhammadAHussain MuhammadAHussain moved this from Backlog (Ready for dev) to Issue in Progress [WIP 12] in Simorgh Jan 26, 2022
Simorgh automation moved this from Issue in Progress [WIP 12] to Done Jan 27, 2022
@MuhammadAHussain MuhammadAHussain moved this from Done to Blocked in Simorgh Jan 27, 2022
Simorgh automation moved this from Blocked to Done Jan 31, 2022
@jroebu14 jroebu14 moved this from Done to Backlog (Ready for dev) in Simorgh Feb 2, 2022
@jroebu14 jroebu14 reopened this Feb 3, 2022
@MuhammadAHussain
Copy link
Contributor

MuhammadAHussain commented Feb 11, 2022

Spoke to Lily about the frequency of errors since PR was merged. It has occurred once since the last PR (#9826) was merged. Issue is low priority for now.

@MuhammadAHussain MuhammadAHussain moved this from Backlog (Ready for dev) to Blocked in Simorgh Feb 16, 2022
Simorgh automation moved this from Blocked to Done Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working low-priority
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants