Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove calls to require in .use #6

Closed
thom4parisot opened this issue Sep 27, 2016 · 0 comments · Fixed by #7
Closed

Remove calls to require in .use #6

thom4parisot opened this issue Sep 27, 2016 · 0 comments · Fixed by #7
Assignees
Milestone

Comments

@thom4parisot
Copy link
Contributor

It is a BC break as a string can be expected and the module gets loaded dynamically.

I'd rather stick to:

const slayer = require('slayer');
const defaultAlgorithm = require('slayer/algorithms/default');

slayer.use(defaultAlgorithm);

And obviously, having it configured by default to avoid the hassle of manually registering it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant