Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the option visibilityTimeout to be configured after initialisation #370

Closed
nicholasgriffintn opened this issue Feb 27, 2023 · 1 comment · Fixed by #379
Closed
Labels
Milestone

Comments

@nicholasgriffintn
Copy link
Member

Problem

As suggested in the discussion here:

#369

It would be good to allow users to configure the option visibilityTimeout after the consumer has started, this will allow users to change the timeout depending on external factors, such as the runtime configuration.

Solution

A new method should be added (possibly something along the lines of changeVisibilityTimeout that will allow the user to provide a new timeout.

The method should verify the provided timeout and then change the option.

It would be good to add a new emitter as well for option changed, users can then listen to this.

We are open to PRs for this change :)

@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant