Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow connections to be made by named input as well as index #1

Closed
MatthewShotton opened this issue Dec 3, 2015 · 2 comments
Closed

Allow connections to be made by named input as well as index #1

MatthewShotton opened this issue Dec 3, 2015 · 2 comments
Labels
💫 enhancement

Comments

@MatthewShotton
Copy link
Contributor

No description provided.

@MatthewShotton
Copy link
Contributor Author

Proposed connection rules.

  • Named connections override connections made by index or connections made by just calling connect.
  • After named connections resulting connections are filled in order by z-index.
  • If Compositing nodes are connected by named input, it's treated the same as a regular connect call with no parameters.
var videoNode, imageNode,canvasNode, effectNode, compositingNode;

videoNode.connect(effectNode, "input_a");
imageNode.connect(effectNode, 2);
canvasNode.connect(effectNode,-1);

/* Resulting Mapping
* videoNode -> input_a
* canvasNode -> input_b
* imageNode -> input_c
*/

@MatthewShotton
Copy link
Contributor Author

Added in commit 766ca62 .

munwaikong referenced this issue in grabyo/VideoContext Dec 26, 2018
@munwaikong
perf tweaks #1 - reducing # of times getUniformLocation() is called d…
78f8064 
…ue to its slow perf due to CPU-GPU sync times (https://developer.mozilla.org/en-US/docs/Web/API/WebGL_API/WebGL_best_practices)
thenikso pushed a commit to thenikso/VideoContext that referenced this issue Jun 4, 2020
@munwaikong @Sacharified
Perf optimization (bbc#1)
d751bc3 
* perf tweaks bbc#1 - reducing # of times getUniformLocation() is called due to its slow perf due to CPU-GPU sync times (https://developer.mozilla.org/en-US/docs/Web/API/WebGL_API/WebGL_best_practices)

* prevent unnecessary calls (every requestAnimationFrame) to texImage2D to 'clearTexture' if it had already been cleare

* tidying up code by 1) renaming typos 2) renaming variables to remain consistent and unambiguous
thenikso pushed a commit to thenikso/VideoContext that referenced this issue Jun 4, 2020
Merge remote-tracking branch 'upstream/develop' into HEAD
78609f7 
* upstream/develop: (22 commits)
  bugfix: fixing a bug where a texutre isn't cleared when expected to due to start() and startAt() setting STATE to be STATE.sequenced before a clearTexture is called.
  Updating typo in a comment
  tidying up code by 1) renaming typos 2) renaming variables to remain consistent and unambiguous
  prevent unnecessary calls (every requestAnimationFrame) to texImage2D to 'clearTexture' if it had already been cleare
  perf tweaks bbc#1 - reducing # of times getUniformLocation() is called due to its slow perf due to CPU-GPU sync times (https://developer.mozilla.org/en-US/docs/Web/API/WebGL_API/WebGL_best_practices)
  0.52.12
  updated CHANGELOG.md
  update docs in preparation for release
  fix effect node alpha blending
  0.52.11
  updated CHANGELOG.md
  update docs in preparation for release
  revert to main field to fix some install errors
  regen yarn lock to point at yarnpkg registry
  cache yarn cache in ci
  0.52.10
  updated CHANGELOG.md
  update docs in preparation for release
  only use yarn
  formatting
  ...
thenikso pushed a commit to thenikso/VideoContext that referenced this issue Jun 4, 2020
@germain-gg
Merge pull request bbc#1 from grabyo/web-audio
b7abf5c 
Web audio bugfixes and add unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💫 enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MatthewShotton