Add images designed by Abbie Brooks. #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| QDEF(MP_QSTR_SWORD, (const byte*)"\x98\x05" "SWORD") | ||
| QDEF(MP_QSTR_GIRAFFE, (const byte*)"\x7d\x07" "GIRAFFE") | ||
| QDEF(MP_QSTR_SKULL, (const byte*)"\x48\x05" "SKULL") | ||
| QDEF(MP_QSTR_BROLLY, (const byte*)"\x63\x06" "BROLLY") |
There was a problem hiding this comment.
Maybe avoid the slang here and just use "umbrella"?
There was a problem hiding this comment.
I did wonder. But I did take two attempts (speed typing) to type UMBRELLA so went for "brolly". :-) Actually Abbie calls it an umbrella so I'll stick with that. Change incoming.
|
For the record, this work was donated via emails exchanged with Abbie's mum Sarah Brooks. This is, obviously, an indication of parental consent for Abbie's work to be included in the micro:bit version of MicroPython. :-) |
|
Very good! I'm happy to merge (rebase needed?), but maybe "stickman" should be something gender neutral like "stick_figure" or "stick_person"? |
|
I'll do that now. Give me 10 mins. |
|
Please merge! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch introduces two changes:
authorslist in thethismodule.