Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question regarding the numerous #if 1 preprocessor directives #3

Closed
DeltaResero opened this issue Dec 17, 2013 · 3 comments
Closed
Labels
wontfix The issue does not describe a behaviour that can be fixed.

Comments

@DeltaResero
Copy link
Collaborator

While I can understand having preprocessor directives "#if 0" or "#if 1" with an "#else" statement, I don't understand why there are so many "#if 1" alone. Are these still relevant for disabling certain blocks of code for debugging because if not the removal of them would help clean up the code a little?

@bbidulock
Copy link
Owner

For forks, I usually try to resist making wide ranging asthetic or other non-functional changes to the code: it makes applying patches based on upstream difficult later. Also, as LPS is a major user of IceWM, non-functional changes still require re-auditing the result. Nevertheless, I forked this version for everyone to use because upstream maintainers appear to have abdicated, so leave this issue open and we will see if we get more supporters of removal.

@bbidulock bbidulock added the wontfix The issue does not describe a behaviour that can be fixed. label Oct 6, 2014
@bbidulock
Copy link
Owner

No takers.

@gijsbers
Copy link
Collaborator

I would support removng the '#if 1' statements. There are 41 of them. Not a huge number.

There are many more '#ifdef/#ifndef LITE' statements. 138 of them. These do clutter the code more. Some of them only remove/add a last argument to a function call. This could be avoided by a #define like:
#define ARGNLITE(x) , x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix The issue does not describe a behaviour that can be fixed.
Projects
None yet
Development

No branches or pull requests

3 participants