Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Allow TaskBarGraphHeight= to be defined in theme file #659

Closed
cheapy opened this issue Jul 7, 2022 · 7 comments
Closed

[Enhancement] Allow TaskBarGraphHeight= to be defined in theme file #659

cheapy opened this issue Jul 7, 2022 · 7 comments

Comments

@cheapy
Copy link

cheapy commented Jul 7, 2022

Currently, in order to support themes to fit different monitor resolutions and sizes, I need to put an entry into prefoverride or change the main preferences value which would affect all themes on all screen types. Otherwise the taskbar/toolbar icon and monitor heights might not be reasonable for the screen.

Following what seems to be a normal convention, I've created theme variants to fit general ranges of screen sizes, and it would make be better if the theme itself could provide a value that overrides the default value in preferences, and which the user could optionally override themselves in prefoverride if needed.
gijsbers added a commit that referenced this issue Jul 8, 2022
@gijsbers
Make TaskBarGraphHeight themable for issue #659.
a47b3cf
@gijsbers
Copy link
Collaborator

Did this help you?

@cheapy
Copy link
Author

cheapy commented Jul 12, 2022

Thanks much! Sorry, I didn't notice a notification before. I will give it a try tomorrow night.

@cheapy
Copy link
Author

cheapy commented Jul 14, 2022

Yes, it worked perfectly, tested as follows:
Default from preferences
override possible by theme
override over theme value by prefoverride

@cheapy
Copy link
Author

cheapy commented Jul 14, 2022

Thanks again!

@cheapy cheapy closed this as completed Jul 14, 2022
@gijsbers
Copy link
Collaborator

Is this sufficient, or do you need/prefer a release?

@cheapy
Copy link
Author

cheapy commented Jul 15, 2022

If you could just include it in the next release, please, that would be great. When I see it's working I'll add it to the themes.

Thanks again :)

@gijsbers
Copy link
Collaborator

It's in the new 2.9.8 release.

kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue Aug 6, 2022
@wangmingyu84 @kraj
icewm: upgrade 2.9.7 -> 2.9.8
eb7b368 
Changelog:
=========
 Omit trailing dot in CPU temperature and add centigrade symbol for issue bbidulock/icewm#652.
 If there is no WM active, then a request to restart will start icewm.
 Don't create the ~/.icewm directory, unless required to save a file.
 When showing the desktop, also minimize a focused fullscreen window.
 Add support for COMPOUND_TEXT title names in WM_NAME strings for issue bbidulock/icewm#26.
 Limit window dimensions to 32732 pixels in the icesh command.
 Improve the truncation of titles for TaskBarTaskGrouping in issue bbidulock/icewm#658.
 Let TaskBarShowAllWindows influence TaskBarTaskGrouping for issue bbidulock/icewm#560.
 Update the TaskBarTaskGrouping menu, when tasks are added or removed.
 Restore the 2.5.0 container handling of button presses for issue bbidulock/icewm#649.
 Make the TaskBarGraphHeight preference themable for issue bbidulock/icewm#659.
 Clarify which preferences are themable in icewm-preferences(5).
 Update the translations for Macedonian and Swedish.

Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
daregit pushed a commit to daregit/yocto-combined that referenced this issue May 22, 2024
@wangmingyu84 @kraj
src/meta-openembedded:icewm: upgrade 2.9.7 -> 2.9.8
dd4fbe1 
Changelog:
=========
 Omit trailing dot in CPU temperature and add centigrade symbol for issue bbidulock/icewm#652.
 If there is no WM active, then a request to restart will start icewm.
 Don't create the ~/.icewm directory, unless required to save a file.
 When showing the desktop, also minimize a focused fullscreen window.
 Add support for COMPOUND_TEXT title names in WM_NAME strings for issue bbidulock/icewm#26.
 Limit window dimensions to 32732 pixels in the icesh command.
 Improve the truncation of titles for TaskBarTaskGrouping in issue bbidulock/icewm#658.
 Let TaskBarShowAllWindows influence TaskBarTaskGrouping for issue bbidulock/icewm#560.
 Update the TaskBarTaskGrouping menu, when tasks are added or removed.
 Restore the 2.5.0 container handling of button presses for issue bbidulock/icewm#649.
 Make the TaskBarGraphHeight preference themable for issue bbidulock/icewm#659.
 Clarify which preferences are themable in icewm-preferences(5).
 Update the translations for Macedonian and Swedish.

Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
daregit pushed a commit to daregit/yocto-combined that referenced this issue May 22, 2024
@wangmingyu84 @kraj
src/meta-openembedded:icewm: upgrade 2.9.7 -> 2.9.8
d109ddc 
Changelog:
=========
 Omit trailing dot in CPU temperature and add centigrade symbol for issue bbidulock/icewm#652.
 If there is no WM active, then a request to restart will start icewm.
 Don't create the ~/.icewm directory, unless required to save a file.
 When showing the desktop, also minimize a focused fullscreen window.
 Add support for COMPOUND_TEXT title names in WM_NAME strings for issue bbidulock/icewm#26.
 Limit window dimensions to 32732 pixels in the icesh command.
 Improve the truncation of titles for TaskBarTaskGrouping in issue bbidulock/icewm#658.
 Let TaskBarShowAllWindows influence TaskBarTaskGrouping for issue bbidulock/icewm#560.
 Update the TaskBarTaskGrouping menu, when tasks are added or removed.
 Restore the 2.5.0 container handling of button presses for issue bbidulock/icewm#649.
 Make the TaskBarGraphHeight preference themable for issue bbidulock/icewm#659.
 Clarify which preferences are themable in icewm-preferences(5).
 Update the translations for Macedonian and Swedish.

Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gijsbers @cheapy