Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Awesome app. some feedback #1

Closed
Code-Slave opened this issue Sep 12, 2021 · 10 comments
Closed

Awesome app. some feedback #1

Code-Slave opened this issue Sep 12, 2021 · 10 comments

Comments

@Code-Slave
Copy link

Want to say I love this and Its really going the way I want. I archive LOTS of channels so if you need any stress testing please let me know.

A couple ideas from others ive used.

Allow custom naming - I use plex or other plugins that need a specific name
Creat .nfo files for plex/kodi etc.
Save metadata and a thumbnail in the channel folder

Alternative channel layout (grid). My archive has 350-400 channels in it so a single column is rough

But seriously. keep on keeping on. Im pretty excited with this

@bbilly1
Copy link
Member

bbilly1 commented Sep 12, 2021

Thanks for the feedback!
Can you be more specific regarding "custom naming"? What exactly do you want to custom name?

  • Regarding .nfo files, I see how that could be useful, I'll take a look into how plex and kodi implement that.
  • Regarding saving metadata and thumbnail in the channel folder, I'm a bit afraid that will have performance impact and will slow down browsing the folder structure with a regular file explorer. As archiving a big channel of for example 5000 videos, will have 5000 nfo files, 5000 thumbnails. Opening that folder on a network share will be slow, I'll need to do some testing.
  • And an definitely yes to the alternate channel layout, that should be straight forward to do.

All in all, thank you for your input!

@Code-Slave
Copy link
Author

Metadata. What kills me is have to redownload in a new app and grab it all again. Some of my channels dont exist anymore. Like i said i archive stuff so barring saving the metadata to a file then an easy way to export the json out to the dir if i need to move or for aome reason project dies.

@Code-Slave
Copy link
Author

Big thing for me. Is if i add a channel im archiving it all. It should grab all the videos metadata when adding a channel.

Also a status in channel details xxx/xxx downloaded. So you know where it is.

Ive added 50 channels and set videos to grab at 5000 so its processing ids for a bit heh

@bbilly1
Copy link
Member

bbilly1 commented Sep 12, 2021

You can download a whole channel by providing the channel ID in the downloads page > add to download queue. This is ideal for an initial download. But to rescan your subscriptions it's not recommended to increase the page size above 50, as this will slow down the whole process drastically and will result in many unnecessary calls to youtube and I'd imagine that you might end up with throttling or even blocking issues. Check out the about page '?' with more details.

@bbilly1
Copy link
Member

bbilly1 commented Sep 12, 2021

Metadata. What kills me is have to redownload in a new app and grab it all again. Some of my channels dont exist anymore. Like i said i archive stuff so barring saving the metadata to a file then an easy way to export the json out to the dir if i need to move or for aome reason project dies.

For indexing none existing videos and channels, the only option for that would be to add the data manually in some sort of a form, possible, but seams like a lot of manual work...

Backing up the metadata is on the to-do list. Right now the intention is an easy way to re-import into a blank database, but exporting that to a JSON or CSV should be easily possible.

@ItsNoted
Copy link

ItsNoted commented Sep 18, 2021

Came to add to this. Phenomenal app! Please add version numbers to the footer so we know which version we are running 👍 Or somewhere else is fine too. And a link back to your github repo!

@bbilly1
Copy link
Member

bbilly1 commented Sep 19, 2021

Yes, you are right, I should definitely have the version number in the footer, this might not be easily detectable else. Then github and docker links have been added already, most likely you haven't pulled the new version yet? And by that of course highlighting the point your are making! :-)

And then a "buy me a coffee link"? Or would that be crazy to think about?

@cactushydrocodone
Copy link

cactushydrocodone commented Oct 6, 2021

Regarding the costum name, i would like to do a custom naming format, is it possible to implement that?

After some bit of grepping, i found the hardcoded format:

tubearchivist/home/src/index.py:326:        filename = f"{timestamp}_{youtube_id}_{clean_title}.mp4"

EDIT: Apparently that line alone doesnt change the filename template, theres more places. But now we know its possible

@bbilly1
Copy link
Member

bbilly1 commented Oct 7, 2021

It's not that it's not possible but it makes things much more complicated. Right now I can be sure where every video file is located on the filesystem on every Tube Archivist installation because the path is build the same way with the same variables. That's a huge help and makes everything much easier.

So the design flaw that makes changing that complicated is that even though you have found where the path gets built and that's also where the path gets written into the index, I depend on having the youtube ID at exactly that location, after the timestamp. The solution to that would be to only set the path once by a flexible predefined set of rules, and then only depend on the path set in the index.

My priorities currently are improving the application and not more flexibility on a filesystem level but that's definitely something to revisit down the road.

#38 goes into the same direction.

@bbilly1
Copy link
Member

bbilly1 commented Oct 19, 2021

closing this old thread for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants