Fix crashes and mismatched tabs in TabView. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Default BTab uses view's name property as tab label, so SetLabel changes that value. However, view names are important for yab and this would cause inconsistencies in view lists yab stores for referencing them by name. Views attached to tabs would not be removed because there is no name "Tab1" in the index (there is "Test1", which is the view's original name). Later, when asking for view with the same name created later yab could get wrong view (if lucky) or crash (if unlucky). This commit fixes that by storing original name in YabView property, and using that for removing views from the hierarchy. * Fixes bbjimmy#5.
|
Also sorry for taking so long to fix this :( |
|
Please hold on with merging this. The problem in Haiku has a larger scope than Yab (hey scripts might use view names and break on localized systems because of current BTab behavior) and I think I have a fix which won't break the ABI. TL;DR should be fixed in Haiku soon. |
|
Thanks for all the hard work! I'll wait for your input on how to proceed from here. |
|
You can merge this PR as is. The described behavior turns out to be a "feature" of BeOS R5 API. BeBook explicitly states that tab's display name is target view's name. It can only be fixed for layout-enabled tab views, which Yab doesn't use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SetLabel changes that value. However, view names are important
for yab and this would cause inconsistencies in view lists yab
stores for referencing them by name. Views attached to tabs would
not be removed because there is no name "Tab1" in the index
(there is "Test1", which is the view's original name).
Later, when asking for view with the same name created later yab
could get wrong view (if lucky) or crash (if unlucky).
This commit fixes that by storing original name in YabView
property, and using that for removing views from the hierarchy.
Adding to that, I will be raising this issue on Haiku's development list, because that behavior is potential source of problems. Additionally, it's not possible to customize tab label rendering without introducing dependency on BControlLook which is problematic.