Cleanup

bblanchon · Jan 12, 2018 · facac2a · facac2a
1 parent d8ede47
commit facac2a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 31 deletions.
diff --git a/test/JsonArray/add.cpp b/test/JsonArray/add.cpp
@@ -78,29 +78,14 @@ TEST_CASE("JsonArray::add()") {
     REQUIRE(str == _array[0]);
   }
 
-  SECTION("should not duplicate string literals") {
-    _array.add("world");
-    const size_t expectedSize = JSON_ARRAY_SIZE(1);
-    REQUIRE(expectedSize == _jsonBuffer.size());
-  }
-
   SECTION("should not duplicate const char*") {
-    const char* str = "world";
-    _array.add(str);
+    _array.add("world");
     const size_t expectedSize = JSON_ARRAY_SIZE(1);
     REQUIRE(expectedSize == _jsonBuffer.size());
   }
 
   SECTION("should duplicate  char*") {
-    const char* str = "world";
-    _array.add(const_cast<char*>(str));
-    const size_t expectedSize = JSON_ARRAY_SIZE(1) + 6;
-    REQUIRE(expectedSize == _jsonBuffer.size());
-  }
-
-  SECTION("should duplicate char[]") {
-    char str[] = "world";
-    _array.add(str);
+    _array.add(const_cast<char*>("world"));
     const size_t expectedSize = JSON_ARRAY_SIZE(1) + 6;
     REQUIRE(expectedSize == _jsonBuffer.size());
   }

diff --git a/test/JsonArray/set.cpp b/test/JsonArray/set.cpp
@@ -78,14 +78,8 @@ TEST_CASE("JsonArray::set()") {
     REQUIRE_THAT(_array[0].as<char*>(), Equals("hello"));
   }
 
-  SECTION("should not duplicate string literals") {
-    _array.set(0, "world");
-    const size_t expectedSize = JSON_ARRAY_SIZE(1);
-    REQUIRE(expectedSize == _jsonBuffer.size());
-  }
-
   SECTION("should not duplicate const char*") {
-    _array.set(0, static_cast<const char*>("world"));
+    _array.set(0, "world");
     const size_t expectedSize = JSON_ARRAY_SIZE(1);
     REQUIRE(expectedSize == _jsonBuffer.size());
   }
@@ -96,13 +90,6 @@ TEST_CASE("JsonArray::set()") {
     REQUIRE(expectedSize == _jsonBuffer.size());
   }
 
-  SECTION("should duplicate char[]") {
-    char str[] = "world";
-    _array.set(0, str);
-    const size_t expectedSize = JSON_ARRAY_SIZE(1) + 6;
-    REQUIRE(expectedSize == _jsonBuffer.size());
-  }
-
   SECTION("should duplicate std::string") {
     _array.set(0, std::string("world"));
     const size_t expectedSize = JSON_ARRAY_SIZE(1) + 6;