Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make printTo stop if it the stream can not take more bytes #211

Closed
wants to merge 1 commit into from

Conversation

me-no-dev
Copy link

also returns the actual bytes written

also returns the actual bytes written
@bblanchon
Copy link
Owner

This increases the code size by 152 bytes, which represents about 4% of the size of the encoding library.
The feature doesn't justify such an increase.
Moreover, there isn't any test.

@me-no-dev, I know the problem you're trying to solve and I know that this is the wrong solution.

One way to solve your issue is to implement coroutine in a Print implementation.
Unfortunately this is currently impossible on the ESP8266 since setjmp() and longjmp() are not yet supported.
I still haven't found any other solution that doesn't ruin the code size and complexity.

I'm sorry but I'm not going to accept this pull request.

@bblanchon bblanchon closed this Jan 28, 2016
Repository owner locked and limited conversation to collaborators Sep 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants