Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benoit,
Many thanks for ArduinoJson. I intend to use it in FirePick Delta for CNC motion control adopting a JSON style of interaction modeled after TinyG. I do very much like your library. For larger projects I use Jansson, but your library is excellent for Arduino with its smaller footprint.
On a minor note, I made a small modification that you may or may not want. I convert long to double automatically. For me this simplifies my code so that I can deal with numbers as double regardless. I'm happy working off my fork--that's the only thing I had to change. I know that it's a slippery slope doing this type of "nice conversion." In this case, I found it worthwhile on the client side. The alternate solution is to provide a new utility method (e.g., asNumber()). After careful consideration, I chose this as less invasive of the API.
Anyhow, thanks for ArduinoJson!