Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to use Visual Studio toolchain? #141

Closed
thbeu opened this issue Nov 1, 2023 · 2 comments
Closed

How to use Visual Studio toolchain? #141

thbeu opened this issue Nov 1, 2023 · 2 comments

Comments

@thbeu
Copy link

thbeu commented Nov 1, 2023

Thanks for this pretty useful build setup.

Is there any change to build with Visual Studio (2019) instead of the Clang toolchain. I tried master...thbeu:pdfium-binaries:build-md but did not succeed. Any help is appreciated. Thanks again.

@bblanchon
Copy link
Owner

Hi @thbeu,

I updated the Windows runner because it came with Python 3.7, and PDFium needs Python 3.9+ to build or it produces the following error:

Traceback (most recent call last):
  File "D:/a/pdfium-binaries/pdfium-binaries/depot_tools/ninja.py", line 14, in <module>
    import gclient_paths
  File "D:\a\pdfium-binaries\pdfium-binaries\depot_tools\gclient_paths.py", line [24](https://github.com/bblanchon/pdfium-binaries/actions/runs/6452203565/job/17513883535#step:11:25), in <module>
    def FindGclientRoot(from_dir, filename='.gclient'):
  File "C:\hostedtoolcache\windows\Python\3.7.9\x64\lib\functools.py", line 490, in lru_cache
    raise TypeError('Expected maxsize to be an integer or None')
TypeError: Expected maxsize to be an integer or None

If we manage to work around this error, we should be about to build with Visual Studio 2019.

BTW, the last build done with Visual Studio 2019 is 119.0.6043.0

Best regards,
Benoit

@thbeu
Copy link
Author

thbeu commented Nov 2, 2023

Thanks for the fast reply and the hint about the recently switched runner from windows-2019 to windows-2022.

I finally could build 120.0.6097.0 with VS 2019 and /MD from my branch build-md, see master...thbeu:pdfium-binaries:build-md.

@thbeu thbeu closed this as completed Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants