Semantic #38
Semantic #38
Conversation
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
build.yml
Outdated
| - path: '/native/build/libs/native-jar-with-dependencies.jar' | ||
| test: | ||
| run: | ||
| # download and use gradle 4.9 since alpine's version is bugged for tests |
There was a problem hiding this comment.
Tests are running on top of openjdk:8-slim, according to the config
There was a problem hiding this comment.
Interesting. Why are they using that if it's the image specificed for "build" that is at the same level as "test"? Adding an image: 'openjdk:8-jre-alpine' inside test will fix it?
There was a problem hiding this comment.
This comment is still not addressed. It tells that "gradle from alpine is broken", but an image that runs tests is not Alpine, it's Debian. Are you sure you still need to download manually grade instead of using a version provided by Debian, or by some PPA?
There was a problem hiding this comment.
Ahh, ok, I misunderstood your comment as saying that I shouldn't run that base image for the tests. I'll take a look at this.
build.yml
Outdated
| - path: src/main/sh/native.sh | ||
| dest: native | ||
| deps: | ||
| - 'apk add gradle' |
There was a problem hiding this comment.
Is it a dependency for running the driver? Why?
There was a problem hiding this comment.
Vestigial, fixed on next commit.
|
|
||
| var Suite = &fixtures.Suite{ | ||
| Lang: "bash", | ||
| Ext: ".bash", |
There was a problem hiding this comment.
I prefer .bash for the fixtures since sh could be understood as POSIX-sh and some tests use bash features.
driver/normalizer/normalizer.go
Outdated
| }, | ||
| Obj{ | ||
| uast.KeyType: Var("_type2"), | ||
| "startOffset": Var("_startOffset2"), |
There was a problem hiding this comment.
Why is startOffset visible here? Preprocessor should take care of it.
There was a problem hiding this comment.
Yeah. Randomly trying things at that point since no matter what I do that annotation doesn't match...
driver/normalizer/normalizer.go
Outdated
| "Node": UASTType(uast.Function{}, Obj{ | ||
| "Type": UASTType(uast.FunctionType{}, Obj{ | ||
| //"Arguments": Var("args"), | ||
| "Arguments": nil, |
There was a problem hiding this comment.
Where is that IsNil() defined? I can't find it in the SDK.
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
build.yml
Outdated
| artifacts: | ||
| - path: '/native/build/libs/native-jar-with-dependencies.jar' | ||
| test: | ||
| image: 'openjdk:8-jre-alpine' |
There was a problem hiding this comment.
I won't work. See FROM native as native_test line in the Dockerfile.
I don't understand why are you trying to test against Alpine version if your build environment is Debian Slim.
There was a problem hiding this comment.
Because some comments above you noted on a line of the "test" section:
"Tests are running on top of openjdk:8-slim, according to the config"
You didnt answered my question as reply of that comment so I understood that I should have added it to the test section.
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
|
@dennwc PR updated to remove the manual gradle download. |
native/Gopkg.toml
Outdated
| @@ -0,0 +1,30 @@ | |||
| # Gopkg.toml example | |||
There was a problem hiding this comment.
These files are probably unused (in native folder)
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
Ready to merge.