Initial version, closes #2, #4, #5, #6 #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcortesm
suggested changes
May 29, 2017
|
|
||
| type clientCmd struct { | ||
| Address string `long:"address" description:"server address to connect to" default:"localhost:9432"` | ||
| Standalone []bool `long:"standalone" description:"run standalone, without server"` |
There was a problem hiding this comment.
Should this be bool instead of []bool?
There was a problem hiding this comment.
Nope, go-flags mandates []bool, which supports detecting things such as -vvvvv.
driver.go
Outdated
| "github.com/bblfsh/sdk/protocol/driver" | ||
| ) | ||
|
|
||
| type Driver interface { |
abeaumont
approved these changes
May 29, 2017
abeaumont
reviewed
May 29, 2017
| Standalone []bool `long:"standalone" description:"run standalone, without server"` | ||
| RuntimePath string `long:"runtime-path" description:"runtime path for standalone mode" default:"/tmp/bblfsh-runtime"` | ||
| ImageRef string `long:"image" value-name:"image-ref" description:"image reference to use (e.g. docker://bblfsh/python-driver:latest)"` | ||
| Language string `long:"language" description:"language of the input" default:"auto"` |
There was a problem hiding this comment.
This option doesn't seem supported yet
alcortesm
approved these changes
May 29, 2017
Merged
* includes CLI for server and client * client can run in standalone mode (--standalone) * handling of images is still very basic * correct handling of concurrent request is still not done
Codecov Report
@@ Coverage Diff @@
## master #12 +/- ##
==========================================
- Coverage 59.28% 47.09% -12.2%
==========================================
Files 7 12 +5
Lines 393 516 +123
==========================================
+ Hits 233 243 +10
- Misses 133 243 +110
- Partials 27 30 +3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.