Set the max number of driver instances to CPU cores #25
Conversation
vmarkovtsev
commented
Jun 14, 2017
vmarkovtsev
commented
- Add the environment variable
vmarkovtsev
force-pushed
the
master
branch
2 times, most recently
from
41f4a82
to
5ed231b
Compare
pool.go
Outdated
| return MovingAverage(10, MinMax(1, 10, AIMD(1, 0.5))) | ||
| maxInstances := 0 | ||
| // Try to read maxInstances from the environment variable | ||
| maxInstancesEnv := os.Getenv("BBLFSH_SCALING_MAX_INSTANCES") |
There was a problem hiding this comment.
I think it'd be better to move this context dependant code outside and pass them as arguments explicitely
There was a problem hiding this comment.
I see that DefaultScalingPolicy() is used in many places, including the tests. What shall I do with all of those?
There was a problem hiding this comment.
@abeaumont that can be done by not using DefaultScalingPolicy() and instantiated it instead.
Nonetheless, this code should be in func init(), initializing a global variable (e.g. DefaulMaxInstancesPerDriver), and then using that variable here.
But you're right that at some point we should move this kind of configuration to server.go and propagate it up to the cli package. I think would leave that to a further PR though.
vmarkovtsev
force-pushed
the
master
branch
2 times, most recently
from
66086af
to
739d5d0
Compare
pool.go
Outdated
| return MovingAverage(10, MinMax(1, 10, AIMD(1, 0.5))) | ||
| maxInstances := 0 | ||
| // Try to read maxInstances from the environment variable | ||
| maxInstancesEnv := os.Getenv("BBLFSH_SCALING_MAX_INSTANCES") |
There was a problem hiding this comment.
@abeaumont that can be done by not using DefaultScalingPolicy() and instantiated it instead.
Nonetheless, this code should be in func init(), initializing a global variable (e.g. DefaulMaxInstancesPerDriver), and then using that variable here.
But you're right that at some point we should move this kind of configuration to server.go and propagate it up to the cli package. I think would leave that to a further PR though.
Codecov Report
@@ Coverage Diff @@
## master #25 +/- ##
==========================================
- Coverage 61.03% 60.49% -0.54%
==========================================
Files 13 13
Lines 675 681 +6
==========================================
Hits 412 412
- Misses 225 229 +4
- Partials 38 40 +2
Continue to review full report at Codecov.
|
vmarkovtsev
force-pushed
the
master
branch
2 times, most recently
from
f9ec4bc
to
96f8939
Compare
|
@smola Did as you said, changed the corresponding test to pass. |
