Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid 'transport closing' errors on client side #299

Merged
merged 1 commit into from
Jul 11, 2019
Merged

Avoid 'transport closing' errors on client side #299

merged 1 commit into from
Jul 11, 2019

Conversation

kuba--
Copy link
Member

@kuba-- kuba-- commented Jul 11, 2019

Signed-off-by: kuba-- kuba@sourced.tech
Addresses: bblfsh/go-client#124
bblfsh/go-client#124 (comment)

This PR sets grpc.KeepaliveEnforcementPolicy to common server options, by decreasing MinTime from 5 to 1 minute and setting PermitWithoutStream to true.

EnforcementPolicy is used to set keepalive enforcement policy on the
server-side. Server will close connection with a client that violates this policy.


This change is Reviewable

Copy link
Member

@dennwc dennwc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @bzz, @creachadair, @kuba--, and @ncordon)


daemon/daemon.go, line 64 at r1 (raw file):

		}),
	)
	opts = append(opts, commonOpt...)

We need to reverse it then: append user options (opts) to the end of commonOpt, so it's possible to override those defaults.

Signed-off-by: kuba-- <kuba@sourced.tech>
Copy link
Member Author

@kuba-- kuba-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @bzz, @creachadair, @dennwc, and @ncordon)


daemon/daemon.go, line 64 at r1 (raw file):

Previously, dennwc (Denys Smirnov) wrote…

We need to reverse it then: append user options (opts) to the end of commonOpt, so it's possible to override those defaults.

Done.

Copy link
Member

@dennwc dennwc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @bzz, @creachadair, and @ncordon)

Copy link
Contributor

@creachadair creachadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @bzz, @creachadair, and @ncordon)

@ncordon
Copy link
Member

ncordon commented Jul 11, 2019

LGTM!

Copy link
Member

@ncordon ncordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @bzz)

Copy link
Member

@dennwc dennwc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @bzz)

@dennwc dennwc merged commit 0a15852 into bblfsh:master Jul 11, 2019
@kuba-- kuba-- deleted the transport-closing branch July 11, 2019 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants