-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid 'transport closing' errors on client side #299
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @bzz, @creachadair, @kuba--, and @ncordon)
daemon/daemon.go, line 64 at r1 (raw file):
}), ) opts = append(opts, commonOpt...)
We need to reverse it then: append user options (opts
) to the end of commonOpt
, so it's possible to override those defaults.
Signed-off-by: kuba-- <kuba@sourced.tech>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @bzz, @creachadair, @dennwc, and @ncordon)
daemon/daemon.go, line 64 at r1 (raw file):
Previously, dennwc (Denys Smirnov) wrote…
We need to reverse it then: append user options (
opts
) to the end ofcommonOpt
, so it's possible to override those defaults.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @bzz, @creachadair, and @ncordon)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @bzz, @creachadair, and @ncordon)
LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 3 files at r1, 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @bzz)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @bzz)
Signed-off-by: kuba-- kuba@sourced.tech
Addresses: bblfsh/go-client#124
bblfsh/go-client#124 (comment)
This PR sets
grpc.KeepaliveEnforcementPolicy
to common server options, by decreasingMinTime
from 5 to 1 minute and settingPermitWithoutStream
totrue
.EnforcementPolicy is used to set keepalive enforcement policy on the
server-side. Server will close connection with a client that violates this policy.
This change is