Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an upstream fix for the zombie problem #79

Merged
merged 3 commits into from
Jul 26, 2017
Merged

Use an upstream fix for the zombie problem #79

merged 3 commits into from
Jul 26, 2017

Commits on Jul 25, 2017

  1. Workaround to use an upstream fix the zombie problem

    The zombie processes problem is a currently open issue of
    opencontainers:
    
    opencontainers/runc#1443
    
    Currently there is a PR that I've tested to work with our use cases:
    
    opencontainers/runc#1506
    
    But Glide doesn't seem to be able to get a version from a PR; and if I add
    LittleLightLittleFire's to the dependencies (and change the imports in the Go
    files) glide then fails with some error related to the other parts of
    libopencontainers and the fork having the same dependencies.
    
    So, this (ugly but simple) workaround in the Makefile was created to use the
    upstream PR so the machine-learning department can continue slurping all the
    code in the world while the upstream PR is merged.
    Juanjo Alvarez committed Jul 25, 2017
    Configuration menu
    Copy the full SHA
    10a940c View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2017

  1. Remove Makefile kludge, do it rightly in glide.* files

    Juanjo Alvarez committed Jul 26, 2017
    Configuration menu
    Copy the full SHA
    a03e9e9 View commit details
    Browse the repository at this point in the history
  2. Set our fork of the fix as source

    Juanjo Alvarez committed Jul 26, 2017
    Configuration menu
    Copy the full SHA
    eef4e91 View commit details
    Browse the repository at this point in the history