This repository has been archived by the owner on Mar 8, 2020. It is now read-only.
fix error handling example #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. |
abeaumont
approved these changes
Jun 28, 2017
| @@ -144,6 +145,11 @@ func main() { | |||
| if err != nil { | |||
| os.Exit(1) | |||
| } | |||
|
|
|||
| if resp.Status != protocol.Ok { | |||
There was a problem hiding this comment.
Since this example is for illustrative purposes, it may be interesting to add an error message per error to better explain what the problem is. In this case something like
Source code has not been parsed correctly, or similar.
There was a problem hiding this comment.
Updated it to include an error message, also making it explicit that resp.Errors might contain multiple errors.
abeaumont
approved these changes
Jun 28, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.