Add missing remaining flow annotations #27
Conversation
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
|
Can you please add them to tests as well? |
…TypeProperty Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
|
@dennwc test improved to cover these too. |
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
|
Usually what should done when creating a driver is get all the possible types from the native driver source code and ensure that the tests cover all of them. Looks like when the initial tests of this driver were created that wasn't done, I'll add a separate issue. |
| col: 19, | ||
| }, | ||
| }, | ||
| Name: "testfnc_object", |
There was a problem hiding this comment.
I can't find annotations in the semantic tree, it seems like some transformation stage cuts them out.
There was a problem hiding this comment.
Yes, should I open an issue?
There was a problem hiding this comment.
It exists in the native tree, so something is wrong with current annotations. Do you want to open a separate issue/PR for it?
There was a problem hiding this comment.
If you check the PR the annotations I added were really pretty simple of the "just add roles to these types" kind. Probably we should just close this PR since it's incomplete anyway because of #28.
There was a problem hiding this comment.
Agree, if by "close" you mean "merge"
Missed a few ones in the last PR.
Related to: #28, #24.
Signed-off-by: Juanjo Alvarez juanjo@sourced.tech