Skip to content
This repository has been archived by the owner on Mar 8, 2020. It is now read-only.

Fix js-specific escape sequence handling #79

Merged
merged 5 commits into from
Mar 29, 2019
Merged

Fix js-specific escape sequence handling #79

merged 5 commits into from
Mar 29, 2019

Conversation

bzz
Copy link
Contributor

@bzz bzz commented Mar 26, 2019 •
edited
Loading

Part of the fix for #75

  • bug fixed for a single quote case
  • " quoted literals handled, same was as ' ones

@bzz
sem: a fixture to reproduce bblfsh#75
9e890df 
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
@bzz bzz self-assigned this Mar 26, 2019
bzz added 2 commits March 28, 2019 21:02
@bzz
sem: fix a bug in js escape seq handling
bbcebed 
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
@bzz
sem: handle js escape seq for double-quote
5430e59 
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
@bzz bzz requested review from dennwc and creachadair March 28, 2019 20:04
@bzz bzz changed the title WIP fix muliple "invalid syntax" bugs Fix multiple "invalid syntax" bugs Mar 28, 2019
@bzz bzz changed the title Fix multiple "invalid syntax" bugs Fix js-specific escape sequence handling Mar 28, 2019
@bzz bzz added this to the v2.7.x milestone Mar 28, 2019
@bzz bzz mentioned this pull request Mar 28, 2019
Closed
3 tasks
creachadair
creachadair reviewed Mar 28, 2019
View reviewed changes
Copy link
Contributor

@creachadair creachadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small things.

driver/normalizer/strconv.go Outdated Show resolved Hide resolved
driver/normalizer/strconv.go Outdated Show resolved Hide resolved
driver/normalizer/strconv.go Outdated Show resolved Hide resolved
driver/normalizer/strconv.go Outdated Show resolved Hide resolved
driver/normalizer/strconv_test.go Show resolved Hide resolved
fixtures/string-literal.js Outdated Show resolved Hide resolved
@bzz
address review suggestions
fd6d585 
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
@bzz bzz force-pushed the fix/escape-in-doublequote-75 branch from 44cf2b5 to fd6d585 Compare March 28, 2019 20:54
@bzz
Copy link
Contributor Author

bzz commented Mar 28, 2019

@dennwc @creachadair thanks for the prompt reviews!
All feedback addressed under fd6d585 and it's ready for another round.

@bzz
sem: re-generated fixtures
06a6ffd 
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
@bzz bzz force-pushed the fix/escape-in-doublequote-75 branch from 5afe9ec to 06a6ffd Compare March 29, 2019 18:23
@bzz bzz merged commit 65c306a into bblfsh:master Mar 29, 2019
@bzz bzz deleted the fix/escape-in-doublequote-75 branch March 29, 2019 18:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@creachadair creachadair creachadair approved these changes

@dennwc dennwc dennwc approved these changes

Assignees

@bzz bzz

Labels
None yet
Projects
None yet
Milestone
v2.7.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bzz @creachadair @dennwc