Skip to content
This repository has been archived by the owner on Mar 8, 2020. It is now read-only.

Bumps sdk version #109

Merged
merged 1 commit into from
Aug 13, 2019
Merged

Bumps sdk version #109

merged 1 commit into from
Aug 13, 2019

Conversation

ncordon
Copy link
Member

@ncordon ncordon commented Aug 13, 2019

Bumps sdk version with fix for the unfolding in the Children iterator

Signed-off-by: ncordon nacho.cordon.castillo@gmail.com


This change is Reviewable

Signed-off-by: ncordon <nacho.cordon.castillo@gmail.com>
Copy link
Member

@dennwc dennwc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ncordon)


go.mod, line 5 at r1 (raw file):

go 1.12

require github.com/bblfsh/sdk/v3 v3.2.3

This looks a bit weird. Why everything else is gone? Is it after go mod tidy? Which version of Go produced the file?

@ncordon
Copy link
Member Author

ncordon commented Aug 13, 2019


go.mod, line 5 at r1 (raw file):

Previously, dennwc (Denys Smirnov) wrote…

This looks a bit weird. Why everything else is gone? Is it after go mod tidy? Which version of Go produced the file?

Yes, I did a go mod tidy, and it's Go version 1.12.7

Copy link
Member

@dennwc dennwc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved


go.mod, line 5 at r1 (raw file):

Previously, ncordon (Nacho Cordón) wrote…

Yes, I did a go mod tidy, and it's Go version 1.12.7

Hmm, that's interesting. I guess they changed the behavior.
CI is green, so we should be fine.

@dennwc dennwc merged commit 1fd3a50 into bblfsh:master Aug 13, 2019
@ncordon ncordon deleted the bump.sdk branch August 13, 2019 13:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants