This repository has been archived by the owner on Mar 8, 2020. It is now read-only.
Bip 5 #16
Merged
Bip 5 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
@dennwc PTAL when you can, all remaining issues should have been fixed. |
dennwc
approved these changes
Jun 6, 2018
driver/fixtures/fixtures_test.go
Outdated
| "gopkg.in/bblfsh/sdk.v2/sdk/driver/fixtures" | ||
| ) | ||
|
|
||
| //const projectRoot = "/opt/driver/src" |
driver/normalizer/annotation.go
Outdated
| On(HasInternalRole("cond")).Roles(uast.Case), | ||
| ), | ||
| func (op opParts2Str) Check(st *State, n uast.Node) (bool, error) { | ||
| if _, ok := n.(uast.String); ok { |
There was a problem hiding this comment.
This check is redundant, since n.(uast.Array) already filters this case
driver/normalizer/annotation.go
Outdated
| ), | ||
| ), | ||
| func (op opParts2Str) Construct(st *State, n uast.Node) (uast.Node, error) { | ||
| n, err := op.orig.Construct(st, n) |
There was a problem hiding this comment.
just return op.orig.Construct(st, n)
|
LGTM! Feel free to squash/merge as necessary. |
- Some HasInternalRole conversions - Assignmnent and opAssign annotations - Added phpast aliases module - More annotations. Reparent native attributes - Some conditional annotations - Some fixes - UncommentCLike working, update to SDK.v2 - Add missing files - Comment positions - Added missing tokens - Delete old tonoder test Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech> Fixed build with v2 fix name transform Signed-off-by: Denys Smirnov <denys@sourced.tech> Cleanup of debug stuff Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech> Remove debug yaml output Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech> Fix Makefile Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech> Fix some unannotated roles Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech> xxx Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech> Fix several issues Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech> Compute line and col from offset instead of using the native ones Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech> Remove the now unneeded attributes object Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech> Join Name.parts into a single string Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech> Fix CI Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech> Fix unannotated name corner case Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech> Fixes from review Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending:
attributesnode (positions are there, are translated but the node remains). Not critical but it's ugly.Name.partsdoesn't get the Unannotated roles and doesn't get new types set. Seems to be an SDK problem, but I'll join them into a single string like the previous driver did.Filemissing on root, even trough I added it directly in the native AST (Fixed: had to delete thebuild/directory to get the image to update).