This repository has been archived by the owner on Mar 8, 2020. It is now read-only.
Increase JSON decoder buffer size to 4Mb #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #127 +/- ##
=======================================
Coverage 39.95% 39.95%
=======================================
Files 21 21
Lines 2115 2115
=======================================
Hits 845 845
Misses 1185 1185
Partials 85 85
Continue to review full report at Codecov.
|
alcortesm
approved these changes
Jun 15, 2017
|
We should use a growable buffer, but let's merge this as a temporary fix. |
smola
approved these changes
Jun 15, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix all "buffer size excedeed" problems with all the Python files I tested (all of the modules in Python 2.7 and 3.6 stdlibs, including some huge ones) but eventually a dynamic allocation alternative will be needed.