Update to v1 and modify Roles to match BIP-003 #171
Conversation
| // The IfElse node is optional. The order of IfCondition, IfBody and | ||
| // IfElse is not defined. | ||
| // The Else node is optional. The order of Condition, Then and | ||
| // Else is not defined. |
There was a problem hiding this comment.
Unrelated: these kind of comments with easy examples of applicability are great. We probably should improve on this on the doc page for creating drivers, with several examples of roles applies for different typical constructs in pseudocode.
There was a problem hiding this comment.
Right, it's difficult to do so without loss of generality though.
uast/uast.go
Outdated
|
|
||
| // Update is |
There was a problem hiding this comment.
Forgot to end the sentence?
uast/uast.go
Outdated
| Import | ||
|
|
||
| // Path is a qualified name of some construct | ||
| Path |
There was a problem hiding this comment.
By the compiler warnings, this could be being overwrited by the Path in line 520.
|
Travis is failing®, looks like that you need to update |
Some roles have ambiguous identifiers that provoked some collisions too, these have also been fixed.
|
@juanjux yes, it was not ready to be merged, it contained only changes to the roles themselves, sorry. |
|
I understand it's ready to merge now? |
Codecov Report
@@ Coverage Diff @@
## master #171 +/- ##
==========================================
+ Coverage 37.72% 37.77% +0.05%
==========================================
Files 21 21
Lines 2399 2401 +2
==========================================
+ Hits 905 907 +2
Misses 1406 1406
Partials 88 88
Continue to review full report at Codecov.
|
|
Right. |
I've added minimal documentation to keep it generic, since it's hard to foresee how roles could be applied to different contexts at this point, but this should be improved as we implement support for them and become more knowledgeable, I think.