Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recover driver list from gRPC and not have a fixed list #89

Closed
mcuadros opened this issue Dec 14, 2017 · 6 comments · Fixed by #122
Closed

Recover driver list from gRPC and not have a fixed list #89

mcuadros opened this issue Dec 14, 2017 · 6 comments · Fixed by #122

Comments

@mcuadros
Copy link
Contributor

We should recover the list of driver installed on the server and the versions, instead of the hardcoded list.

@smacker
Copy link
Collaborator

smacker commented Dec 14, 2017

Do you think we should add method to client-go or call bblfshd gRPC directly from dashboard?

@mcuadros
Copy link
Contributor Author

The better will be call to gRPC: https://godoc.org/github.com/bblfsh/bblfshd/daemon/protocol, otherwise you will need to parse an ASCII table.

In this case we will need use dep because this API is not versioned.

@smacker
Copy link
Collaborator

smacker commented Jan 10, 2018

Let's wait for decision about this proposal first: https://github.com/bblfsh/client-go/pull/32

@bzz
Copy link
Contributor

bzz commented Mar 28, 2018

As soon as bblfsh/client-go#32 is merged now and before adding new drivers at #119 let's move forward with this.

@dpordomingo would you mind adding it to Applications project, so it shows up on our backlog? Thanks in advance!

@dpordomingo
Copy link
Member

@bzz done
(and added some context with related issues at #119 (comment))

@dpordomingo
Copy link
Member

The implementation proposed at #89 (comment) was done by #122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants