Body matching oddities

[dolzenko]

So I have just discovered a few oddities in the way Webmock matches request bodies, since I have already had to delve into internals I will use internal API for demonstration too:

 > WebMock::BodyPattern.new(a: 1, b: 2).matches?({a: 1, c: nil}.to_json, 'application/json')
 => true

In other words - body matching algorithm [1] seems surprising to me, i.e. stubbed and actual bodies should have the same size, but then having different keys in stubbed and actual is accepted. If we agree that this should be changed, my proposition would be to compare actual keys, not the sizes of the both bodies.

[1] https://github.com/bblimke/webmock/blob/master/lib/webmock/request_pattern.rb#L224

[bblimke]

Thanks for reporting this. It is definitely an incorrect behaviour.

[bblimke]

Fixed in master.

[dolzenko]

Fantastic, thanks a lot! And for the mention too ;)