em-http-request: do not alter non stubbed requests #1005
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this change: #936
We are now altering the header that are sent when using webmock and em-http-request in
WebMock.allow_net_connect!
modeIf you check here https://github.com/igrigorik/em-http-request/blob/34919d760b940dfd27159bbebce5c4dac9845eb6/lib/em-http/client.rb#L180 when forwarding the request to em-http-request, the
send_request
method expects some headers to be downcased (otherwise they are doubled)This is an issue for example for
Content-Length
which would be interpreted as an array in the receiving webserver and not as a number.The idea of the fix is to keep the raw_headers (not normalized by webmock) and use those raw_headers when forwarding the request