Fix CONTENT_LENGTH in RackResponse #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cheers, you're right. I'm happy to merge it once travis passes :) |
|
Fixed magic encoding. Still one test fails with jruby-head. It also fails without my commit, so I suggest it is a bug in Net::HTTP implementation in jruby :-/ |
|
Ok, I'll have to deal with rake issue in master. Thanks! |
bblimke
added a commit
that referenced
this pull request
Mar 27, 2014
Fix CONTENT_LENGTH in RackResponse
|
Although travis failed on rake. Actually there's an issue with PR itself on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I think RackResponse calculates CONTENT_LENGTH wrongly. It takes body.size. But if body has non-ASCII symbols, they will be stored in two bytes each but the length of each of them will be one.
I'm confident it is right to take body.bytesize instead.