use VALID_REQUEST_KEYS constant for Excon if defined #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice thanks. The specs use Ruby >1.9 hash syntax. Can you change to |
|
@bblimke done. |
|
Cheers! :) |
bblimke
added a commit
that referenced
this pull request
Aug 10, 2014
use VALID_REQUEST_KEYS constant for Excon if defined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #403
While digging further into this, I was able to track down the introduction of the constant to release 0.27.0:
excon/excon@a93c591
So I thought it'd be nice to just get rid of that
if Excon::VERSION >= '0.27.5'and replace with a constant check. Also added a spec to make sure it's not broken.Ran specs locally and everything looks green.