Fix Json parse problem with multibyte characters #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbegin
force-pushed
the
fix-parse-json-by-byte
branch
3 times, most recently
from
40fe7ec
to
acc8fa2
Compare
it looks like this error was never actually defined, and no spec that calling this code path
davidbegin
force-pushed
the
fix-parse-json-by-byte
branch
from
a6f06b7
to
df600b7
Compare
Ruby 1.9.2 does not support byteslice Ruby 1.8.7 does not support force_encoding forcing this code to branch for Ruby 1.9.2 and convert the string to binary and then back to UTF-8
davidbegin
added a commit
that referenced
this pull request
Sep 3, 2015
Fix Json parse problem with multibyte characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.