Add API to reset registry requests #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bblimke
reviewed
Jun 5, 2018
README.md
Outdated
| stub_get = stub_request(:get, "www.example.com") | ||
| Net::HTTP.get('www.example.com', '/') | ||
|
|
||
| WebMock::RequestRegistry.instance.times_executed(stub_get.request_pattern) # => 1 |
There was a problem hiding this comment.
WebMock::RequestRegistry.instance.times_executed is not part of the API.
perhaps it's better to show examples with expect(stub_get).to have_been_requested.times(1)
and then expect(stub_get).not_to have_been_requested ?
There was a problem hiding this comment.
Sure, I will change this!
There was a problem hiding this comment.
I have moved it in the stubs section to be more consistent.
They have changed their site to return an empty response if Accept is not specified. Fixes the tests that depend on those responses.
oliakremmyda
force-pushed
the
reset_requests
branch
from
c376560
to
47285c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #760