(#16) Modal & Drawer Component #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baegofda
force-pushed
the
feature/modal-drawer-component
branch
from
0a217dd
to
9fbe092
Compare
Benj846
previously approved these changes
Nov 24, 2023
cause38
previously approved these changes
Nov 24, 2023
|
package 변경시 이유 작성 좋습니다 |
shinYeongHyeon
previously approved these changes
Nov 26, 2023
(#16) Modal & Drawer Component
baegofda
dismissed stale reviews from shinYeongHyeon, cause38, and Benj846
via
0bd6c2b
baegofda
force-pushed
the
feature/modal-drawer-component
branch
from
9fbe092
to
0bd6c2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(#16) Modal & Drawer Component
Modal과 Drawer에 관한 기본적인 레이아웃만 제공합니다.
또한 Modal, Drawer의 렌더링이 될 DOM위치를 정할
<div id = {"modal"} />형식의 요소가 필요합니다.
"@types/react": "18.2.0"가 추가되었습니다.createPortal 사용 시 타입 에러가 발생하였고 @types/react와 @types/react-dom의 버전 불일치로 인한 타입 에러였습니다.
참고 이슈