Skip to content
This repository has been archived by the owner on Aug 14, 2021. It is now read-only.

Update Gradle build not to include frontend when compiling Java on your local machine #9

Closed
linovifian opened this issue Mar 25, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@linovifian
Copy link
Collaborator

Currently when developing locally, most of the time one has to wait for the build to finish. This is rather time consuming and should be improved

  • check if the build can be done incrementally, e.g. only recompiling things that have been changed
  • definetly don't run prettier, linter and coverage in the normal local build
@linovifian linovifian added the enhancement New feature or request label Mar 25, 2020
@linovifian linovifian added this to To do in POC Game / Release 1.0.0. via automation Mar 25, 2020
@bbortt
Copy link
Owner

bbortt commented Mar 26, 2020

It's because of the build dependencies defined in build.gradle.kts (backend depends on frontend):

withType<ProcessResources> {
        dependsOn("src:main:Buessle-Webapp:npmExport")
        from("src/main/webapp/out") {
            into("static")
        }
}

One needs to fully build the React application in order to statically move it into the final .jar file. This includes linting and testing.
On the other hand, this is clearly not needed when developing on your local machine. I'll see what I can do.

@bbortt bbortt changed the title Reduce build time Update Gradle build not to include frontend when compiling Java on your local machine Mar 26, 2020
@bbortt bbortt moved this from To do to In progress in POC Game / Release 1.0.0. Mar 26, 2020
@bbortt bbortt moved this from In progress to Review in progress in POC Game / Release 1.0.0. Mar 26, 2020
bbortt added a commit that referenced this issue Mar 28, 2020
…in-local-dev

Bugfix/#9 do not compile frontend in local dev
@bbortt bbortt closed this as completed Mar 28, 2020
POC Game / Release 1.0.0. automation moved this from Review in progress to Done Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
No open projects
Development

No branches or pull requests

2 participants