Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API backwards compatibility update, reinstate old addRecipient API as deprecated #101

Closed
amanteaux opened this issue Sep 2, 2017 · 4 comments
Closed

API backwards compatibility update, reinstate old addRecipient API as deprecated #101

amanteaux opened this issue Sep 2, 2017 · 4 comments
Assignees
@bbottema
Labels
enhancement Priority-High
Milestone
4.4.5

Comments

@amanteaux
Copy link
Contributor

In version 4.4.x, the method Email.addRecipient(String, String, RecipientType) has been deleted whereas it was not even deprecated before.

Would it be possible to put back this method as deprecated in the 4.x.x branch and plan to remove it in the 5.x.x major release?
It would really make Simple Java Mail users feel more confident about this library.
If possible, breaking changes should append as little as possible and should not be taken lightly.
@bbottema
Copy link
Owner

bbottema commented Sep 2, 2017

You're absolutely right. I hadn't even thought of it until you mentioned it. I'll add them back deprecated asap

@amanteaux
Copy link
Contributor Author

Thank you a lot!

@bbottema bbottema added this to the 4.4.5 milestone Sep 2, 2017
bbottema added a commit that referenced this issue Sep 2, 2017
@bbottema
#101: keep the old addRecipient API as deprecated to give library use…
6285abe 
…rs time to migrate
@bbottema bbottema self-assigned this Sep 2, 2017
@bbottema bbottema changed the title Email.addRecipient should not be removed in a feature release API backwards compatibility update, reinstate old API as deprecated Sep 2, 2017
@bbottema bbottema changed the title API backwards compatibility update, reinstate old API as deprecated API backwards compatibility update, reinstate old addRecipient API as deprecated Sep 2, 2017
@bbottema
Copy link
Owner

bbottema commented Sep 2, 2017 •
edited
Loading

Released in 4.4.5. If you can, please let me know if this is what you expected.

@bbottema bbottema closed this as completed Sep 2, 2017
@amanteaux
Copy link
Contributor Author

Wow that was quick!
This is perfect, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbottema bbottema

Labels
enhancement Priority-High
Projects
None yet
Milestone
4.4.5
Development

No branches or pull requests
2 participants
@bbottema @amanteaux