Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For a concise and more flexible API, completely replace Mailer constructors with MailerBuilder. Add support completely ignoring property defaults. #115

Closed
bbottema opened this issue Nov 5, 2017 · 1 comment
Closed

For a concise and more flexible API, completely replace Mailer constructors with MailerBuilder. Add support completely ignoring property defaults. #115

bbottema opened this issue Nov 5, 2017 · 1 comment
Assignees
@bbottema
Labels
enhancement major feature Priority-Low
Milestone
5.0.0

Comments

@bbottema
Copy link
Owner

bbottema commented Nov 5, 2017

Currently, the constructors are growing wild in the Mailer class. This is due to the fact that, programmaticcally, there is no invalid combination of parameters as any missing argument can be compensated with a property default.

As such, to keep the Mailer API simple and flexible at the same time, all constructors should be replaced in favor of a new MailerBuilder class.
@bbottema bbottema added this to the 5.0.0 milestone Nov 5, 2017
@bbottema bbottema self-assigned this Dec 5, 2017
@bbottema bbottema changed the title For a concise and more flexible API, completely replace all Mailer constructors with a new MailerBuilder For a concise and more flexible API, completely replace Mailer constructors with MailerBuilder. Add support completely ignoring property defaults. Dec 8, 2017
bbottema added a commit that referenced this issue Dec 24, 2017
@bbottema
#115: overhauled how Mailers are created and initialized. Everything …
eaa7677 
…now works exclusively through builders, including property defaults.
@bbottema
Copy link
Owner Author

Released as 5.0.0.rc1-SNAPSHOT. Add OSS' snapshots repo to find it in Maven.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbottema bbottema

Labels
enhancement major feature Priority-Low
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
1 participant
@bbottema