Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Support Exchange proprietary addresses (X.500 DAP) #477

Closed
dwlabcube opened this issue Oct 24, 2023 · 4 comments
Closed

Enhancement: Support Exchange proprietary addresses (X.500 DAP) #477

dwlabcube opened this issue Oct 24, 2023 · 4 comments
Milestone

Comments

@dwlabcube
Copy link

When the recipient is a "strange" address in a .msg file the MiscUtil will throw.
java.lang.IllegalArgumentException: emailAddressList is required
at org.simplejavamail.internal.util.Preconditions.verifyNonnullOrEmpty(Preconditions.java:49) ~[core-module-8.3.1.jar:na]
Suppressed: reactor.core.publisher.FluxOnAssembly$OnAssemblyException:

Please see the attachment in order to get an idea of how that address looks like.
Unfortunately i can not share the email with you since it holds sensitive data and I do not know how to reproduce it easily.

emailListTo

It seems to have it's root in handleNameAddressProperty in OutlookRecipient class
AddressParser

Suggestion:
erase the null check in MiscUtil and just log a warning instead of throwing an exception.
Or add a check in handleNameAddressProperty that does not check only on @ but also has an OR with startsWith("/o")

@dwlabcube
Copy link
Author

I created a Pull request in the outlookmessageparser repo:
dwlabcube:patch-X500-Outlook-Recipient

@bbottema
Copy link
Owner

bbottema commented Oct 24, 2023

Is that even a value Outlook/Exchange can resolve? I don't think I've ever seen an address value like this, but perhaps it's valid Exchange-speak.

@dwlabcube
Copy link
Author

Yes outlook was able to resolve it properly. It seems to be something with caching and resolving X500 Address or something like that. I have no clue about all that, but it seems to be valid stuff though.

if you google for "/o=exchangelabs/ou=exchange administrative group" you'll find some information. but honestly i didn't get it what exactly is going on.

if you don't mind just accepting empty email-address in the miscutil i am very fine with it as well.
maybe there is even a cleaner solution?

@bbottema bbottema changed the title Recipient as Exchange Member will throw Exception emailAddressList is required Support Exchange proprietary addresses Oct 24, 2023
@bbottema bbottema changed the title Support Exchange proprietary addresses Enhancement: Support Exchange proprietary addresses (X.500 DAP) Dec 3, 2023
bbottema added a commit that referenced this issue Dec 3, 2023
… X.500 DAP MS Exchange supported addresses when parsing Outlook messages
@bbottema bbottema added this to the 8.3.3 milestone Dec 3, 2023
@bbottema
Copy link
Owner

bbottema commented Dec 3, 2023

8.3.3 was released with improved X500 support when parsing Outlook messages!

@bbottema bbottema closed this as completed Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants