Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A single EmailBuilder would build emails that all share the same collections for recipients, attachments and embedded images #94

Closed
bbottema opened this issue Aug 14, 2017 · 1 comment
Closed

A single EmailBuilder would build emails that all share the same collections for recipients, attachments and embedded images #94

bbottema opened this issue Aug 14, 2017 · 1 comment
Labels
bug Priority-High
Milestone
4.4.4

Comments

@bbottema
Copy link
Owner

Currently, if one were to reuse an EmailBuilder to create multiple emails, then changing one Email instance would affect all the other Email instance (and in fact newly create Email instances from the same EmailBuilder).

Blocks #90.
@bbottema bbottema added this to the 4.4.0 milestone Aug 14, 2017
@bbottema bbottema self-assigned this Aug 14, 2017
@bbottema bbottema mentioned this issue Aug 14, 2017
Closed
bbottema added a commit that referenced this issue Aug 15, 2017
@bbottema
#94: always return new collections when building an email from an Ema…
dc9eddd 
…ilBuilder, making it reusable (as designed). Note that the objects within these lists are already immutable.
@bbottema
Copy link
Owner Author

Release in 4.4.0. Please verify.

@bbottema bbottema removed their assignment Aug 18, 2017
@bbottema bbottema modified the milestones: 4.4.2, 4.4.0, 4.4.3 Aug 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Priority-High
Projects
None yet
Milestone
4.4.4
Development

No branches or pull requests
1 participant
@bbottema