Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds apiKey to parameters list, fixes broken API calls. #2

Merged
merged 7 commits into from
Dec 6, 2017
Merged

Adds apiKey to parameters list, fixes broken API calls. #2

merged 7 commits into from
Dec 6, 2017

Conversation

lacymorrow
Copy link
Contributor

Noticed it was broken, hope this helps fix!

Used within lacymorrow/cinematic.

@bbraithwaite bbraithwaite self-requested a review November 15, 2017 15:51
@lacymorrow
Copy link
Contributor Author

What do you think about this PR? Can it be pulled into the codebase?

@bbraithwaite
Copy link
Owner

bbraithwaite commented Dec 6, 2017

Sorry for the delay here, I've been very busy recently. Yes of course, thank you!

Copy link
Owner

@bbraithwaite bbraithwaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bbraithwaite bbraithwaite merged commit a600dbb into bbraithwaite:master Dec 6, 2017
@lacymorrow
Copy link
Contributor Author

lacymorrow commented Dec 6, 2017

Awesome, thank you for helping me get those pulled in!
Needed to fix some downstream code that broke when the API began requiring keys by updating this package.

Users will need secure API keys from omdb and update their code to include those keys.

I would recommend a major version bump, as older versions not using an api key should now be non-functional.

@lacymorrow
Copy link
Contributor Author

Will be closing lacymorrow/ombd-client fork as the npm libs are registered and pulled into the downstream code.

@lacymorrow
Copy link
Contributor Author

Excellent! Thanks for this, I'm going to be pulling this into downstream code after it's registered with npm and removing my fork lacymorrow/lacymorrow-omdb-client :)

@lacymorrow
Copy link
Contributor Author

Thanks so much for the merge!
Let me know when you bump the version and re-publish to npmJS.org, I'll delete my fork and pull your library back into my project lacymorrow/cinematic.

Cheers!

@lacymorrow lacymorrow mentioned this pull request Feb 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants