-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds apiKey
to parameters list, fixes broken API calls.
#2
Conversation
What do you think about this PR? Can it be pulled into the codebase? |
Sorry for the delay here, I've been very busy recently. Yes of course, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Awesome, thank you for helping me get those pulled in! Users will need secure API keys from omdb and update their code to include those keys. I would recommend a major version bump, as older versions not using an api key should now be non-functional. |
Will be closing lacymorrow/ombd-client fork as the npm libs are registered and pulled into the downstream code. |
Excellent! Thanks for this, I'm going to be pulling this into downstream code after it's registered with npm and removing my fork |
Thanks so much for the merge! Cheers! |
Noticed it was broken, hope this helps fix!
Used within lacymorrow/cinematic.