Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many extension constants are written to external.go #43

Closed
bbredesen opened this issue Mar 31, 2023 · 0 comments · Fixed by #44
Closed

Many extension constants are written to external.go #43

bbredesen opened this issue Mar 31, 2023 · 0 comments · Fixed by #44
Labels
bug/minor Not working as intended, but with low or no impact

Comments

@bbredesen
Copy link
Owner

The intent of exten.go is to group the constant name and spec version strings for all extensions. Some values are written to exten.go, but the majority are written into external.go. This bug does not appear to be present in platform specific extensions (i.e. exten_win32.go has all of the win32 extension values), but that could be a sampling error d/t the relatively small number of platform extensions.

Some extensions are even split between the two files, i.e. spec version is in exten.go and extension name is in external.go.

The quantity and specific set of extensions that are written in one or another file is different on each run of vk-gen, even with the same input file.

@bbredesen bbredesen added the bug/minor Not working as intended, but with low or no impact label Mar 31, 2023
bbredesen added a commit that referenced this issue Apr 13, 2023
bbredesen added a commit that referenced this issue Nov 21, 2023
Fix for #43, set cat on every value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/minor Not working as intended, but with low or no impact
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant