Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generics require go 1.18 #9

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Generics require go 1.18 #9

merged 1 commit into from
Mar 7, 2023

Conversation

asmaloney
Copy link
Contributor

No description provided.

@bbredesen
Copy link
Owner

I see no issue w/ the update to 1.18 and will merge this in, but it's worth noting that it isn't strictly necessary for vk-gen.

The only use of generics is in static_include/static_mem.go. gopls will complain about that file, but it is only embedded in the output and not actually compiled as part of vk-gen. (1.18+ is of course required for go-vk though, because it does compile in those generic functions.)

I use VS Code and added the following to my settings.json, I presume a similar mechanism is available in most editors.

    "gopls": {
        "directoryFilters": [
            "-static_include"
        ],
    }

@bbredesen bbredesen merged commit 80ab070 into bbredesen:main Mar 7, 2023
@asmaloney asmaloney deleted the generics branch March 7, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants